Basic Guidelines For New L2J-DataPack Developers

These are not rules as such, they are just guidelines to help new developers get familiar with the way other developers make changes.

• Always add comments to your commits saying what you have changed/added.

• Changes to data in files are generally fine.

• Regarding changes to sql files:
  • Keep the file header (the table creation portion) in the same format as the original.
  • Try to use the same format for inserts as the original file. Doing this makes it easier to view changes when comparing revisions.
  • If the changes are smaller manual entry or cutting and pasting is often better than redumping the entire table unless your dump is in the same format as the original file.

• Changes to structure of the datapack (moving/renaming main directories and sql files) affect everybody and should be kept to a minimum and done with caution, and discussed before they are done.

• Be confident that what you are changing (adding) is a correct change (addition), or close to correct, especially if it could cause people to exploit the server this especially applies to spawnlist.sql, droplist.sql merchant_buylists.sql and npc.sql.

• If you break something it's your responsibility to fix it :)